[module] GCam Patch

[simonsmh]

Fix slow motion & 60fps not working on Google camera.
This module could works on most of the devices. Actually this module is mostly for non-nexus devices, which is considered not supported by Google Camera. By default other devices can't even open slomo and they will expect ANR immediately. This module fixes some missing media profiles and makes slomo working again. The basic logic is simple, Nexus devices won't need such kind of module.
https://github.com/simonsmh/magisk-gcam-patch

 

[rajkatiyar07]

Fix slow motion & 60fps not working on Google camera.

https://github.com/simonsmh/magisk-gcam-patch

Tested device ? is it working on HTC 10 ? anyone ?

 

[simonsmh]

Tested device ? is it working on HTC 10 ? anyone ?

Should working on all devices, please try it first.
I personally tested it on mido and oneplus 3, and it works.

 

[Fif_]

Should working on all devices, please try it first.
I personally tested it on mido and oneplus 3, and it works.

Really?
I inspected the Magisk module you posted and the GitHub repo and this module does not seem to do anything:
- post-fs is disabled
- late service is disabled
- properties are disabled
- automount is enabled, but there is no system directory.
Shouldn't that do absolutely nothing? [emoji6]

 

[simonsmh]

Really?
I inspected the Magisk module you posted and the GitHub repo and this module does not seem to do anything:
- post-fs is disabled
- late service is disabled
- properties are disabled
- automount is enabled, but there is no system directory.
Shouldn't that do absolutely nothing? [emoji6]

have you read all my commit?

 

[simonsmh]

Really?
I inspected the Magisk module you posted and the GitHub repo and this module does not seem to do anything:
- post-fs is disabled
- late service is disabled
- properties are disabled
- automount is enabled, but there is no system directory.
Shouldn't that do absolutely nothing? [emoji6]

Have you read all my commit?

 

[Fif_]

Have you read all my commit?

No, just the zip and tip of master in GitHub.

 

[simonsmh]

No, just the zip and tip of master in GitHub.

https://github.com/simonsmh/magisk-...NF/com/google/android/update-binary#L160-L171

 

[Fif_]

https://github.com/simonsmh/magisk-...NF/com/google/android/update-binary#L160-L171

Duh. My bad. Apologies.
I solved a similar problem by doing the same thing in the post-fs script at every boot instead of an install script once at install time, so that I could catch ROM updates.
You may want to use this sed construct to make a nicer xml file:
sed -e '/<\/CamcorderProfiles>/{' \
-e 'i<EncoderProfile blah' \
-e 'iline 2' \
etc
-e '}'

I'll try your module now that I get what it does...

 

[bunklung]

Total newbie here to modules and Magisk. Does this module do the same as this:

https://xdaforums.com/showpost.php?p=70748865&postcount=161

This module doesn't seem to do anything for me. I have performed the manual file manipulation in the past, but slow motion breaks. I was hoping this module did both slow motion and 60fps.

Nexus6P Oreo Oct Patch.

Thanks.

 

[rajkatiyar07]

Not working at all on my HTC 10.

 

[simonsmh]

Not working at all on my HTC 10.

Please try 1.2 version which is on official repo.

 

[simonsmh]

Total newbie here to modules and Magisk. Does this module do the same as this:

https://xdaforums.com/showpost.php?p=70748865&postcount=161

This module doesn't seem to do anything for me. I have performed the manual file manipulation in the past, but slow motion breaks. I was hoping this module did both slow motion and 60fps.

Nexus6P Oreo Oct Patch.

Thanks.

Please try 1.2 version which is on official repo.

 

[infernusdark]

Nexus 6P Oreo

Enviado desde mi Nexus 6P mediante Tapatalk

 

[simonsmh]

Nexus 6P Oreo

Enviado desde mi Nexus 6P mediante Tapatalk

Screen

 

[rajkatiyar07]

Please try 1.2 version which is on official repo.

slomo still not working. Viewfinder is there but not able to record.

 

[bunklung]

Please try 1.2 version which is on official repo.

Doesn't seem to do anything on my 6P. I don't see a 30/60fps option in video record mode. 120/240 works, but that always works when 60fps is off.

Seems default to me.

 

[infernusdark]

Screen

I select 60FPS

Enviado desde mi Nexus 6P mediante Tapatalk

 

[simonsmh]

Doesn't seem to do anything on my 6P. I don't see a 30/60fps option in video record mode. 120/240 works, but that always works when 60fps is off.

Seems default to me.

BSG edited Google camera has 60fps recording mode. This module works on that one.

 

[simonsmh]

I select 60FPS

Enviado desde mi Nexus 6P mediante Tapatalk

Please post /magisk/gcam-patch/system/etc/media_profile.xml here.